Fix/dd race condition #380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct log level on canceled chunkProcessingJob
Prevents unnecessary logging of chunk processing job cancellation in non-debug mode. This change reduces log clutter by only logging the cancellation of the chunk processing job when the debug flag is enabled.
Moves the `finishDepotDownload` call to after all depots have been processed. This resolves a race condition where the download completion logic could be triggered before all files were fully downloaded, leading to incomplete or corrupted downloads.
Ensures that the onDownloadCompleted event is notified on the main thread to prevent potential race conditions when updating the UI or other thread-sensitive components. Also, handles the case where the AppItem is not found gracefully.
Moves the listener notification to an IO dispatcher to avoid potential race conditions when listeners perform long-running operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist