Fixes to handle unacknowledged command with pod faults correctly #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Clear unacknowledgedCommand on a fault return from non-status command + Rework to correctly handle previous unacknowledgedCommand on pod fault + Guard against negative bolus if dose cancel is called incorrectly
itsmojo
approved these changes
Jun 29, 2025
Contributor
itsmojo
left a comment
itsmojo
left a comment
There was a problem hiding this comment.
I did a lot of testing of this for a # of corner cases involving interrupted boluses and unacknowledged commands that were previously incorrectly handled which are now all handled correctly in all cases with this changes.
Collaborator
Author
|
See testing done with rPi and OmniBLE. |
This was referenced Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Fix the corner case where a pod fault is treated as an unacknowledged command during an interrupted bolus and the undelivered insulin is subtracted twice from the original bolus amount.
This was reported for both Trio and Loop (the two apps use a common set of OmniBLE and OmniKit modules):
Method
Recognize that getting a fault return from a pod, 0x202, should not be treated the same as not getting a podStatus return, 0x1d return. In other words, this is not an unacknowledged command.
Make sure the interrupted bolus is handled in only one place.
Ensure that the delivered insulin can never be negative.
Test
This was tested by @itsmojo who provided the code modification. Once the PR are in place, this will be tested again.