Skip to content

Update dd-logs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LossyDragon merged 7 commits into from
Jan 2, 2026
Merged

Update dd-logs #9

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e8632a
Adds debug check for chunk cancellation log
joshuatam Jan 1, 2026
7e9b579
Fixes race condition during download completion
joshuatam Jan 1, 2026
fc01e15
Fixes race condition in download completion
joshuatam Jan 1, 2026
20a6e12
Fixes potential race condition
joshuatam Jan 1, 2026
4b9739b
Update SampleDownloadApp for changed download flow
joshuatam Jan 2, 2026
312968d
Adds auto-start option to DepotDownloader
joshuatam Jan 2, 2026
50ba53a
use startDownloading() on Init()
joshuatam Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions ...depotdownloader/src/main/kotlin/in/dragonbra/javasteam/depotdownloader/DepotDownloader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ import kotlin.text.toLongOrNull
* @param maxFileWrites Number of concurrent files being written. Default: 1
* @param androidEmulation Forces "Windows" as the default OS filter. Used when running Android games in PC emulators that expect Windows builds.
* @param parentJob Parent job for the downloader. If provided, the downloader will be cancelled when the parent job is cancelled.
* @param autoStartDownload Whether to start downloading automatically. If false, you must call [startDownloading] manually.
*
* @author Oxters
* @author Lossy
Expand All @@ -123,6 +124,7 @@ class DepotDownloader @JvmOverloads constructor(
private var maxFileWrites: Int = 1,
private val androidEmulation: Boolean = false,
private val parentJob: Job? = null,
private val autoStartDownload: Boolean = true,
) : Closeable {

companion object {
Expand Down Expand Up @@ -245,6 +247,12 @@ class DepotDownloader @JvmOverloads constructor(
}
}

if (autoStartDownload) {
startDownloading()
}
}

fun startDownloading() {
// Launch the processing loop
scope.launch {
processItems()
Expand Down Expand Up @@ -952,6 +960,8 @@ class DepotDownloader @JvmOverloads constructor(
"(${downloadCounter.totalBytesUncompressed} bytes uncompressed) from ${depots.size} depots"
)
}

finishDepotDownload(mainAppId)
}

private suspend fun processDepotManifestAndFiles(
Expand Down Expand Up @@ -1199,7 +1209,7 @@ class DepotDownloader @JvmOverloads constructor(
// Cancel the continuous flow job since no more chunks will be added
chunkProcessingJob?.cancel()

logger?.debug("Canceled chunk processing job for depot ${depot.depotId}")
if (debug) logger?.debug("Canceled chunk processing job for depot ${depot.depotId}")
}
}

Expand Down Expand Up @@ -1244,10 +1254,6 @@ class DepotDownloader @JvmOverloads constructor(
}

if (debug) logger?.debug("Depot ${depot.depotId} - Downloaded ${depotCounter.depotBytesCompressed} bytes (${depotCounter.depotBytesUncompressed} bytes uncompressed)")

if (isLastDepot) {
finishDepotDownload(mainAppId)
}
}

private suspend fun downloadSteam3DepotFile(
Expand Down Expand Up @@ -1600,7 +1606,18 @@ class DepotDownloader @JvmOverloads constructor(
private suspend fun finishDepotDownload(mainAppId: Int) {
val appItem = processingItemsMap[mainAppId]
if (appItem != null) {
if (debug) {
logger?.debug("Notifying onDownloadCompleted")
}
notifyListeners { it.onDownloadCompleted(appItem) }
} else {
if (debug) {
logger?.error("AppItem not found, cannot notify onDownloadCompleted")
}
}

if (debug) {
logger?.debug("Complete the completionFuture.")
}

completionFuture.complete(null)
Expand Down