Fix Android build by fixing your preprocessor guards#704
Closed
DaKup wants to merge 3 commits intoLostRuins:concedofrom
Closed
Fix Android build by fixing your preprocessor guards#704DaKup wants to merge 3 commits intoLostRuins:concedofrom
DaKup wants to merge 3 commits intoLostRuins:concedofrom
Conversation
Owner
|
it should already be fixed in the experimental build. i just haven't merged that since there are other incomplete changes |
Owner
|
Can you see if this commit works for you? |
Owner
|
Looks like their fix has another issues, let me sort it out first ggml-org#5557 |
Owner
|
Should be resolved now. Please reopen if still not working! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the latest version doesn't compile on android/termux.
It said something about affinity**_np**() not being available and it looks like you already knew this and put the respective preprocessor guards around the relevant code, but simply missed these ones.
Thanks!