Skip to content

gemma2: add sliding window mask#959

Closed
Nexesenex wants to merge 1 commit intoLostRuins:concedo_experimentalfrom
Nexesenex:gemma
Closed

gemma2: add sliding window mask#959
Nexesenex wants to merge 1 commit intoLostRuins:concedo_experimentalfrom
Nexesenex:gemma

Conversation

@Nexesenex
Copy link
Copy Markdown

@Nexesenex Nexesenex commented Jul 1, 2024

Expand the usable context from 5k to 8k.

ggml-org#8227

Additional commits :

fix data_swa uninitialized
better naming
add co-author

fix data_swa uninitialized

better naming

add co-author

Co-Authored-By: Arlo Phoenix <arlo-phoenix@users.noreply.github.com>
@Nexesenex
Copy link
Copy Markdown
Author

The PR works as it is beyond the previous 5k context cap for Gemma V2 softcap.
Slaren just wants to simplify the code.

@LostRuins
Copy link
Copy Markdown
Owner

I'll think i will wait to merge this when it's merged in llama.cpp

@Nexesenex Nexesenex closed this Jul 1, 2024
@Nexesenex
Copy link
Copy Markdown
Author

And merged it is, with a further drop in perplexity ! :D

@Nexesenex Nexesenex deleted the gemma branch July 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants