minarch: fixes for DOSBox frame rate sync#620
Merged
frysee merged 1 commit intoLoveRetro:mainfrom Feb 26, 2026
Merged
Conversation
pvaibhav
force-pushed
the
main
branch
3 times, most recently
from
7beec00 to
5dc3c72
Compare
Author
|
Any comments? |
Member
|
Havent had a chance to look at it, sorry. We've been sorting out a few of the bigger contribtutions recently. I'll get to it eventually, thanks for contributing! |
frysee
approved these changes
Feb 26, 2026
- Properly sync current values for config knobs when using CORE_OPTIONS_V2 so cores see config values during init - Honor SET_SYSTEM_AV_INFO and SET_GEOMETRY to keep fps/aspect in sync (fixes DOSBox Pure force output FPS until toggle) Note that DOSBox pure is not part of NextUI right now, but these minarch fixes are necessary for any external DOS pak to work.
Member
|
Sorry this one took so long! |
Author
|
Great!! I’m continuing to work on dosbox compatibility and improvements, as it seems just this fix isn’t enough. Will send more PRs when I have significant progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #619 (comment) for details on the issue this PR closes.