Add background color as an appearance setting#661
Open
radther wants to merge 6 commits intoLoveRetro:mainfrom
Open
Add background color as an appearance setting#661radther wants to merge 6 commits intoLoveRetro:mainfrom
radther wants to merge 6 commits intoLoveRetro:mainfrom
Conversation
Member
|
Gave it a brief test, a couple of issues I found:
|
frysee
reviewed
Feb 26, 2026
frysee
reviewed
Feb 26, 2026
| void PLAT_clearLayers(int layer) { | ||
| if(layer==0 || layer==1) { | ||
| SDL_SetRenderTarget(vid.renderer, vid.target_layer1); | ||
| SDL_SetRenderDrawColor(vid.renderer, vid_bgR, vid_bgG, vid_bgB, 255); |
Member
There was a problem hiding this comment.
We could just do a CFG_getColor(COLOR_BACKGROUND) here, and avoid having to maintain and call PLAT_setBackgroundColor at all.
Member
1: Still happening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new background color option to the appearance pane of settings. This color should fill the screens background, replacing the existing black/clear appearance.
Why
Allows for more customisation theming without needing background images. The color can be combined with the other colors for fun themes.
How