Conversation
paulmelero
left a comment
paulmelero
left a comment
There was a problem hiding this comment.
👏🏽 LGTM
As you said, we would need to update the README too.
| // common ones | ||
| // biblio | ||
| semi: ['error', 'never'], | ||
| quotes: [ | ||
| 'error', | ||
| 'single', | ||
| { avoidEscape: true, allowTemplateLiterals: true }, | ||
| ], | ||
|
|
||
| // wf | ||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', | ||
|
|
||
| // ydr | ||
|
|
||
| // bib-service-projects | ||
| 'require-atomic-updates': 'warn', | ||
| }, |
There was a problem hiding this comment.
The fact that these were originally linked to specific projects still makes them suitable for node or jest environments, I would move them to the shared file 🙏🏽
There was a problem hiding this comment.
should we just remove (or have as a goal to remove eventually) anything for specific projects and have those projects just override any of the default settings they want to be diff?
There was a problem hiding this comment.
To be honest, I didn't include 100% of their rules. Only the ones that I considered to be best practices. And also, semi and quotes match the prettier config. So we don't have issues using prettier-config and eslint-config together, which is what I'd recommend.
There was a problem hiding this comment.
The references to different projects are left there only to indicate that we did a "merge" of all the different preferences everyone had. To highlight that it was done as democratically as possible.
There was a problem hiding this comment.
After reviewing it again, these rules that were in the index.js file are all good for node.js, including the extended configurations.
| extends: ['plugin:jest/recommended'], | ||
| plugins: ['jest'], |
There was a problem hiding this comment.
This requires us to have the eslint-plugin-jest dependency as well. And add it in the readme as a requirement alongside the other dependencies...
| 'plugin:node/recommended', | ||
| ], | ||
| plugins: ['node'], |
There was a problem hiding this comment.
same here with https://www.npmjs.com/package/eslint-plugin-node
|
And sorry, I never pulled off continuing with #4 |
paulmelero
requested review from
achimoraites,
ashmenon,
danield-ltk and
dansalias
ashmenon
removed request for
achimoraites,
ashmenon,
danield-ltk and
dansalias
2 participants
Docs need to be updated.