Add/Fix parfor shared variable in Murat_dataParallelized#48
Merged
Conversation
Add envelope function in bin and readme on how to use it in input file. also modified line 52 in Murat_Qc.m
Added the envelopeSmoothTime parameter to all example input files (MSH, Romania, Toba) in the Waveform Data section, ensuring consistency with the updated Murat_envelope.m function and README documentation
Replaced shared counter `countTrash` with a logical mask `trashMask` inside the parfor loop.
Each iteration now marks discarded traces independently using:
trashMask(i) = true
The total number of rejected traces is computed after the loop with:
countTrash = sum(trashMask)
This improves robustness and follows best practices for parallel MATLAB loops, avoiding potential issues with shared/reduction variables.
No changes in results or workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced shared counter
countTrashwith a logical masktrashMaskinside the parfor loop.Each iteration now marks discarded traces independently using:
trashMask(i) = true
The total number of rejected traces is computed after the loop with:
countTrash = sum(trashMask)
This improves robustness and follows best practices for parallel MATLAB loops, avoiding potential issues with shared/reduction variables.
No changes in results or workflow.