FormatterExpression Optimization#152
Closed
cjberg wants to merge 2 commits intoLuckyPennySoftware:masterfrom
cjberg:FormatterExpression-Optimization-Nov27
Closed
FormatterExpression Optimization#152cjberg wants to merge 2 commits intoLuckyPennySoftware:masterfrom cjberg:FormatterExpression-Optimization-Nov27
cjberg wants to merge 2 commits intoLuckyPennySoftware:masterfrom
cjberg:FormatterExpression-Optimization-Nov27
Conversation
…ls with basic string manipulations (Regex was unnecessary and expensive).
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed my web application spent four seconds creating mappings at start-up. Most of the time was used by Regex.Replace calls in FormatterExpression. I looked at the source and realized that the use of Regex.Replace was quite unnecessary and expensive, considering how simple the transformations were. By replacing all regexes with simpler string functions, the start-up time was cut to a quarter, down from four to about one second.
I hope you want to accept this pull request, since it does make a significant difference, without making the code more complex. All tests pass, of course.