Fix review feedback: double semicolon, DI condition integration test, docs example#4601
Merged
jbogard merged 2 commits into4562-dependency-injection-in-conditionsfrom Feb 20, 2026
Merged
Conversation
… update docs Co-authored-by: jbogard <104498+jbogard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add DI support for conditions and pre-conditions in AutoMapper
Fix review feedback: double semicolon, DI condition integration test, docs example
Feb 20, 2026
jbogard
approved these changes
Feb 20, 2026
7e9f34a
into
4562-dependency-injection-in-conditions
3 checks passed
This was referenced Mar 4, 2026
Closed
Closed
This was referenced Mar 14, 2026
Closed
Closed
mlapaglia
pushed a commit
to mlapaglia/OpenAlprWebhookProcessor
that referenced
this pull request
Mar 23, 2026
Updated [AutoMapper](https://github.com/LuckyPennySoftware/AutoMapper) from 16.0.0 to 16.1.1. <details> <summary>Release notes</summary> _Sourced from [AutoMapper's releases](https://github.com/LuckyPennySoftware/AutoMapper/releases)._ ## 16.1.1 ## What's Changed * Better async handling of license validation; fixes #4612 by @jbogard in LuckyPennySoftware/AutoMapper#4613 * More artifacts for builds (test results and SBOM) by @jbogard in LuckyPennySoftware/AutoMapper#4615 * Update Microsoft.Sbom.DotNetTool to 4.1.5 by @jbogard in LuckyPennySoftware/AutoMapper#4616 ## Security Fixed an issue where certain cyclic or self-referential object graphs could trigger uncontrolled recursion during mapping, potentially resulting in stack exhaustion and denial of service. Applications that process untrusted or attacker-controlled object graphs through affected mapping paths may be impacted. Users should upgrade to this release. Security advisory: GHSA-rvv3-g6hj-g44x Thanks to @bluefossa for responsibly disclosing this issue. **Full Changelog**: LuckyPennySoftware/AutoMapper@v16.1.0...v16.1.1 ## 16.1.0 ## What's Changed * Add Debug and Release build configurations to slnx by @Copilot in LuckyPennySoftware/AutoMapper#4590 * Migrating to slnx by @jbogard in LuckyPennySoftware/AutoMapper#4589 * Allow disabling of polymorphic LINQ mapping by @jbogard in LuckyPennySoftware/AutoMapper#4596 * Fix duplicate BOM in ServiceCollectionExtensions.cs by @Copilot in LuckyPennySoftware/AutoMapper#4600 * Fix review feedback: double semicolon, DI condition integration test, docs example by @Copilot in LuckyPennySoftware/AutoMapper#4601 * Adding DI-enabled conditions and pre-conditions; updated docs accordi… by @jbogard in LuckyPennySoftware/AutoMapper#4599 * Adding support for DI-enabled destination factories. by @jbogard in LuckyPennySoftware/AutoMapper#4603 * Correctly converting nullables for MapAtRuntime; fixes #4597 by @jbogard in LuckyPennySoftware/AutoMapper#4604 * Correctly handling consecutive uppercase characters; fixes #4593 by @jbogard in LuckyPennySoftware/AutoMapper#4605 * Wrapping the exception to provide better feedback to the user; fixes … by @jbogard in LuckyPennySoftware/AutoMapper#4606 * Fixing bug around order of open generic registration by @jbogard in LuckyPennySoftware/AutoMapper#4607 * Adding perpetual licensing by @jbogard in LuckyPennySoftware/AutoMapper#4608 ## New Contributors * @Copilot made their first contribution in LuckyPennySoftware/AutoMapper#4590 **Full Changelog**: LuckyPennySoftware/AutoMapper@v16.0.0...v16.1.0 Commits viewable in [compare view](LuckyPennySoftware/AutoMapper@v16.0.0...v16.1.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/mlapaglia/OpenAlprWebhookProcessor/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments on the DI-enabled conditions PR. Three issues corrected:
LicenseAccessor.cs:57— Remove stray extra semicolon (}; ;→};)MapperConfigurationwithservices.AddAutoMapper(...)in the class-based conditions DI example; the old example wouldn't trigger automatic condition registrationConditionDependencyTeststoAutoMapper.DI.Testsdemonstrating constructor-injected dependencies in a condition class resolved viaAddAutoMapper:Also updates three existing
ShouldConfigureProfilestype-map count assertions (4 → 5) to account for the newConditionProfilemap.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.