Fixed undefined symbols PRIu64/PRIu32 and reference to clock_gettime#736
Merged
davidlunarg merged 1 commit intoMar 7, 2019
Conversation
Fixed undefined symbols PRIu64/PRIu32 by including <cinttypes> instead of <inttypes.h> Fixed undefined reference to clock_gettime by linking rt library
Contributor
Author
|
In case you have not been notified automatically, I signed the CLA on Feb 28 2019. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On CentOS6.8 with a local build of g++ 6.4.0 (the default g++ version on CentOS6.8 is 4.4.7), the build fails with undefined symbol PRIu64 and PRIu32 at compile time and undefined reference to 'clock_gettime' at link time.
Fixed undefined symbols PRIu64/PRIu32 by including
<cinttypes>instead of<inttypes.h>. (a less elegant solution would be to add#define __STDC_FORMAT_MACROSprior to include<inttypes.h>).layersvt/device_simulation.cppis a C++ file and as such should include C header files that way anyway (note that this file includes other C header files the wrong way:<stdarg.h>,<stdio.h>,<stdlib.h>and<string.h>instead of<cstdarg>,<cstdio>,<cstdlib>and<cstring>respectively. I have not fixed these inclusions in the current patch as I want to keep it minimal to address the actual build issue)Fixed undefined reference to clock_gettime by linking rt library
This fix is similar to KhronosGroup/SPIRV-Tools#2409