fix(ci): allow sdk publish after partial native release#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the TypeScript SDK release workflow continue to the main SDK publish even when one or more native runtime package jobs fail. This prevents the root SDK release from being skipped just because some platform-native package legs fail or lag.
Changes
.github/workflows/release-typescript-sdk.yml: add a job-levelif: always() && needs.verify.result == successgate onpublish-sdkso it still runs after failed native matrix legs.github/workflows/release-typescript-sdk.yml: change the npm indexing wait loop to collect visible and missing native packages instead of hard-failing on the first missing package.github/workflows/release-typescript-sdk.yml: emit a warning when some native packages are still missing, but continue with the SDK publish pathFor slice-related changes, include:
ts-sdk-vX.Y.ZflowMotivation
Business motivation:
The root TypeScript SDK package needs to publish even when some platform-native package jobs fail, so release throughput is not blocked by partial platform breakage.
Technical motivation:
The previous workflow skipped
publish-sdkwhenever anypublish-nativematrix leg failed, and the npm wait step also hard-failed when any optional native package was missing.Alternative approaches considered:
Scope and impact
.github/workflows/release-typescript-sdk.ymlTesting
Commands/results:
Results:
actcontrol harness: one native matrix leg succeeded, one failed, and the realpublish-sdkpack step still executed successfullysdks/dist/npm/lythaeon-sof-sdk-0.1.1.tgzRelated issues and documentation
ts-sdk-v0.1.1release behaviordocs/architecture/README.mdReviewer checklist
docs/architecture/ard/0003-slice-dependency-contracts.md)Additional notes
This PR does not retrigger any release tag. It only changes the workflow behavior for future tag or manual release runs.