fix(ci): use pnpm for SDK publish registry checks#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the TypeScript SDK publish helper on Windows runners by removing the direct
npmbinary dependency from the registry existence check.Changes
sdks/typescript/scripts/publish-package.mjs: usepnpm viewinstead ofnpm viewfor the “already published?” check before publish.Motivation
Business motivation:
Unblock the
0.1.1TypeScript SDK release on Windows native package jobs.Technical motivation:
The GitHub Actions Windows bash runner had
pnpmavailable for the publish step, butspawnSync("npm")failed withENOENTinside the helper script.Alternative approaches considered:
Resolving
npm-cli.jsrelative to the Node installation was unnecessary once the workflow already standardized onpnpmfor publish.Scope and impact
Testing
Commands/results:
Both commands behaved as expected: existing published versions skipped cleanly, and a missing version returned a normal nonzero status without an execution error.
Related issues and documentation
0.1.1.ts-sdk-v0.1.1release recovery.docs/architecture/README.mdReviewer checklist
docs/architecture/ard/0003-slice-dependency-contracts.md)Additional notes
After merge, the
ts-sdk-v0.1.1tag should be moved onto the newmaincommit before rerunning the release workflow.