fix(ci): stop SDK publish after native cancel#105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop TypeScript SDK release workflows from publishing the SDK after native publish jobs were manually cancelled. This closes the current release control gap where
publish-sdkcould keep running and polling npm even after the native matrix had been cancelled.Changes
Detailed list of what changed:
.github/workflows/release-typescript-sdk.yml: addedactions: readso the workflow can inspect its own job conclusions through the Actions API.github/workflows/release-typescript-sdk.yml: tightened thepublish-sdkjob gate fromalways()to!cancelled().github/workflows/release-typescript-sdk.yml: added a native job conclusion check before SDK install/wait/publish.github/workflows/release-typescript-sdk.yml: updated the npm indexing wait loop to stop early when any native publish job is cancelled.github/workflows/release-typescript-sdk.yml: preserved the existing partial-success behavior for native failures, but no longer treats explicit cancellation as eligible for SDK publishFor slice-related changes, include:
Motivation
Business motivation:
Technical motivation:
publish-nativeusescontinue-on-error: true, sopublish-sdkwas still allowed to run.Alternative approaches considered:
Scope and impact
Testing
Commands/results:
Related issues and documentation
docs/architecture/README.mdReviewer checklist
docs/architecture/ard/0003-slice-dependency-contracts.md)Additional notes
This change only affects release control flow. It does not change package contents or publish order when all native jobs run normally.