fix(ci): publish SDK packages with shell pnpm#106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the TypeScript SDK release workflow on Windows by removing the Node helper script from the publish path. The workflow already performs the npm existence checks in shell, and those checks succeed on Windows. The remaining failure came from invoking
pnpmfrom inside a Node child process during publish.Changes
Detailed list of what changed:
.github/workflows/release-typescript-sdk.yml: changed native package publish to runpnpm publish --access public --no-git-checksdirectly in the workflow shell.github/workflows/release-typescript-sdk.yml: changed SDK publish to runpnpm publish --access public --no-git-checksdirectly in the workflow shellnode .../publish-package.mjsresolvingpnpminside a spawned child process on WindowsFor slice-related changes, include:
Motivation
Business motivation:
ts-sdk-v0.1.2and avoid more failed release reruns.Technical motivation:
pnpmsteps worked on Windows.spawnSync pnpm ENOENTbecause the child-process resolution path differed from the runner shell environment.Alternative approaches considered:
publish-package.mjsresolve a platform-specificpnpmbinary. Rejected because the workflow already had a working shell-level package manager path, so the simpler and more reliable fix is to use it directly.Scope and impact
Testing
Commands/results:
Related issues and documentation
spawnSync pnpm ENOENTon Windows publish jobs for the TypeScript SDK releasedocs/architecture/README.mdReviewer checklist
docs/architecture/ard/0003-slice-dependency-contracts.md)Additional notes
This is intentionally workflow-only. The publish helper remains in the tree, but release CI no longer depends on it for publishing.