Conversation
967ecaa to
7ff83a9
Compare
7ff83a9 to
6d561ce
Compare
48aed19 to
d33d024
Compare
d33d024 to
a7def34
Compare
f92cb2d to
b2a5919
Compare
8304abd to
2f1dff3
Compare
jjfrench
reviewed
Dec 11, 2024
jjfrench
reviewed
Dec 11, 2024
jjfrench
reviewed
Dec 11, 2024
jjfrench
reviewed
Dec 11, 2024
jjfrench
reviewed
Dec 11, 2024
jjfrench
reviewed
Dec 11, 2024
jjfrench
reviewed
Dec 11, 2024
jjfrench
approved these changes
Dec 11, 2024
Member
jjfrench
left a comment
There was a problem hiding this comment.
Sorry for the late review! I left some comments/questions but everything looks good overall! 🚀
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
titiler-pgstac and any other serverless functions that can send many simultaneous requests to the pgstac database can quickly overwhelm the database resources. This PR adds an EC2 instance running
pgbouncerto the MAAP eoAPI stack, providing connection pooling for titiler-pgstac requests.Features
pool_mode = transactionprovides high performance for many inbound requeststestdeployment which is running at3.microRDS instance is performing significantly better* than thet3.smallinstance on thedevdeploymenttestdeployment is basically unusable for rendering large-scale mosaics.Questions
pgbouncerconfiguration settings be dynamic according to the pgstac database size? @bitnerThis is one approach for solving https://github.com/NASA-IMPACT/active-maap-sprint/issues/1052