GH-642: Redesigning PendingPayableScanner #677

bertllll · 2025-07-30T23:28:12Z

No description provided.

…rgotten to update with the last changes from the other card

… and maybe continued fixing issues even beyond the point (sry)

…y thinks done at a time)

…ayable scanner; various From and Display implementations and these sorts

…inst the mark pending payable rowid fn

…es...opened in its own PR and then will start from here on

…ig changes emerged

…leton

…earrange the code a bit - maybe to add a separative class

node/src/accountant/scanners/pending_payable_scanner/mod.rs

node/src/accountant/scanners/pending_payable_scanner/utils.rs

node/src/accountant/scanners/pending_payable_scanner/mod.rs

utkarshg6

Continue at node/src/accountant/scanners/pending_payable_scanner/mod.rs:795

node/src/accountant/scanners/pending_payable_scanner/mod.rs

utkarshg6

Nicely done @bertllll

…or failing tests

utkarshg6

It's ready for merge!

bertllll and others added 30 commits June 24, 2025 17:39

GH-642: interim commit

326b79b

GH-642: interim commit

b73925a

GH-642: interim commit

0071b8e

GH-642: big initial messy reconstruction continuing...

da59853

GH-642: big initial messy reconstruction... just realized I may've fo…

9276aad

…rgotten to update with the last changes from the other card

GH-642: big initial messy reconstruction... finished other card merge…

a24cbc1

… and maybe continued fixing issues even beyond the point (sry)

GH-642: merged in Utkarshe's help (Quick PR to unload me from too man…

fbbfaa9

…y thinks done at a time)

GH-642: tests compiling...failing lots of them

ce84ef4

GH-642: fn confirm_transactions has been reimplemented

2b3cc52

GH-642: fn handle_failed_transactions has been reimplemented

1b3abb5

GH-642: fixed mainly internal, but smaller functions in the pending p…

1573bde

…ayable scanner; various From and Display implementations and these sorts

GH-642: progressed quite greatelly; fixed many tests; took action aga…

c42b6d0

…inst the mark pending payable rowid fn

GH-642: another bunch fixed...down to 24

6d17bf6

GH-642: another bunch fixed...down to 10

c299f91

GH-642: the base of this card is done

7e224e4

GH-642: lots of fixes in names

4515d82

GH-642: filling cache with failed txs to recheck at startup

6ef6f0f

GH-642: merged in a contribution from Utkarsh

874d1c8

GH-642: rpc failers during receipt checks can be handled now

4aa18d4

GH-642: interim commit

9e2fc52

GH-642: first I need to finish the impl of the db system of tx status…

0d10884

…es...opened in its own PR and then will start from here on

GH-642: finally compiling after merge from GH-598; the need for new b…

9e07df1

…ig changes emerged

GH-642: pending payable scanner machinery has been given the true ske…

21368d7

…leton

GH-642: before creating a new whole folder for scanner utils

c1127c5

GH-642: merged file reorganization in scanners

1554a88

GH-642: interim commit

e1506ea

GH-642: preparing tests before writing the guts of the core fns

e8e2428

GH-642: integration of the caches...100% at start_scan, 90% finish_scan

b2f4c77

GH-642: another big portion of work in interpreting the receipts

2eb5ea4

GH-642: finishing tests for the receipt interpretation but I should r…

e16c21a

…earrange the code a bit - maybe to add a separative class