Skip to content

Conversation

@bertllll
Copy link
Contributor

@bertllll bertllll commented Nov 18, 2025

Note

Refactors outbound payments handling to send a single SentPayables (success or error) and avoid duplicate ScanError notifications; tests updated to match.

  • BlockchainBridge (node/src/blockchain/blockchain_bridge.rs):
    • Refactor handle_outbound_payments_instructions to use then and always emit one SentPayables message (success or error), returning Ok(()) to suppress propagation and avoid duplicate error notifications.
    • Add TODO explaining temporary workaround to prevent duplicate scanner panics.
  • Tests:
    • Update expectations by commenting out ScanError assertions and adjusting message counts (now only SentPayables recorded).

Written by Cursor Bugbot for commit 5f93de9. This will update automatically on new commits. Configure here.

Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@bertllll bertllll merged commit 858adfa into GH-598 Nov 19, 2025
1 check passed
@bertllll bertllll deleted the GH-598-hot-fix-panic-bug branch November 19, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants