Skip to content

AntiAFK and login failure changes#18

Closed
dbear20 wants to merge 9 commits intoMCCTeam:Indevfrom
dbear20:master
Closed

AntiAFK and login failure changes#18
dbear20 wants to merge 9 commits intoMCCTeam:Indevfrom
dbear20:master

Conversation

@dbear20
Copy link

@dbear20 dbear20 commented Sep 25, 2013

Made the antiAFK bot's message configurable through the .INI file (still defaulted to /ping). I also changed the login failure behavior from pause and wait for user input to automatically trying to reconnect after 10 seconds, this setting is also configurable in the.INI file. In case it was missed in the original pull request I apologize for any sloppy codeing or formatting as I have absolutely no experience with it.

ORelio and others added 5 commits August 8, 2013 03:59
Merging changes from Indev for 1.6.0 release
Merging changes from Indev for 1.6.1 release
Added the ability to set a custom test string for the antiAFK bot
through the .ini file. Also changed it that instead of waiting for input
after login failure it waits 10 seconds and then restarts the program to
try again.
Now displays time till reconnect on login failure
Newbie error with github, this has the time till reconnect messages.
@ORelio
Copy link
Member

ORelio commented Sep 28, 2013

Hello, sorry for the late reply I've been busy these last days.

  • The antiAFK command setting is a nice idea!
  • Would it be better to automatically reconnect only if the autorelog bot is enabled?
  • I see you added a signing manifest thing with a key. What's the purpose of this?

@dbear20
Copy link
Author

dbear20 commented Sep 29, 2013

Thats ok i'm basically just messing around with this anyway, i figured i might as well share what i feel are improvements with the community.

  • In regards to only reconnect if the autorelog bot is enabled is perhaps a possible idea but once again knowing absolutely nothing about coding i'm limited on what i can do, currently the only thing affected by it is a failure upon even logging into the server, i figured for those that did the single command function would rather it try and recconect automatically since it never had the chance to run their command.
  • As for the signing manifest, that can also be attributed to me being a newb and not checking any of the default settings in visual studio, half the changes were somehow automatically done by it. Since then i have found the signing manifest setting and disabled it. I'll go back through and revert the code that was changed at some point.

@dbear20
Copy link
Author

dbear20 commented Oct 14, 2013

Ok i managed to remove the manifest and i tried putting in a setting to disable the auto retry on login failure but it proved too much for me so i didn't push it into the pull.

@featherbear
Copy link

What's the status of this pull?

@ORelio
Copy link
Member

ORelio commented Jan 16, 2014

There are unnecessary changes in MinecraftClient.csproj, MinecraftClient.csproj.user, I think I'll manually add the changes to the repository and then "close" the pull request.

@dbear20
Copy link
Author

dbear20 commented Jan 17, 2014

I'm totally OK with that I've never coded anything before let alone visual basic. I think I'll just suggest ideas instead of trying to code them myself.

@dbear20
Copy link
Author

dbear20 commented Jan 17, 2014

*sorry with visual studio

@featherbear
Copy link

Don't worry mate, every coder has to start somewhere. And it's better late then never.
Just go through your VS settings and try find out what else is happening to the code, and a simple google search is bound to show you how to stop it from happening :)

@ORelio
Copy link
Member

ORelio commented Jan 17, 2014

When adding a new commit using the GitHub desktop app, you can uncheck visual studio related files.

ORelio added a commit that referenced this pull request Jan 17, 2014
- AntiAFK command can be customized through INI file
- Clearer WriteDefaultSettings() function
@ORelio
Copy link
Member

ORelio commented Jan 17, 2014

AntiAFK custom command feature has been added in commit no. a627842
Thanks for your contribution!

@ORelio ORelio closed this Jan 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants