Skip to content

Indev#5

Merged
ORelio merged 12 commits intoMCCTeam:Indevfrom
featherbear:Indev
Jul 20, 2013
Merged

Indev#5
ORelio merged 12 commits intoMCCTeam:Indevfrom
featherbear:Indev

Conversation

@featherbear
Copy link

Created .gitignore for /bin and /obj (Using VS2012)
Moved dll files to /lib folder (Aesthetic)
Added appicon.ico into resources folder.
Spelling Mistake Fix.
Put configs in folder.

@ORelio
Copy link
Member

ORelio commented Jul 19, 2013

Nice changes :)

  • Thanks for fixing the "lenght" typo and adding gitignore files, I knew how to ignore file on SVN but not on GIT
  • hangman config files could be named hangman-words.txt and hangman-mots.txt instead of putting them in a subfolder. Folders are useful but one folder for two files is not an optimal sorting ^^
  • In the future I plan to merge them in a single INI file as suggested by bSun0000 here: http://www.minecraftforum.net/topic/1314800-windows-minecraft-console-client-162/page__st__80#entry21620232
  • you introduced some spelling mistakes in the error messages of the french hangman bot: You should say "Fichier file.txt" instead of "file.txt Fichier" ;)
  • The icon is nice -- although I'm not sure that's necessary for a console application. How about putting a green glowing creeper face instead of the grass block item on the icon? :)

Is there a way for you to modify the pull request to fix the issues before merging it?

@featherbear
Copy link
Author

Yes.
just commit it again

@ORelio
Copy link
Member

ORelio commented Jul 19, 2013

That's better :) There are still some spelling mistakes but I'll fix them later.
Regarding the icon, I didn't meant to replace the whole icon, but editing it to keep the console prompt but change the small block to a creeper face.

Typo: dictionnary -> dictionary
@ORelio
Copy link
Member

ORelio commented Jul 19, 2013

Ah, You're writing a scripting bot :)
I had the same idea but never did it.

Basically, a file would contain a list of instructions, one per line:

  • send /mycommand
  • wait 60
  • send Hello world!
  • exit

The first word of the instruction would define the type of the instruction, followed by a space.
Anything following the first space is the argument, if any.
When the client is connected, the bot starts reading the file, one instruction per tick (MCC is running at 10 tps) unless an intruction delays the following command. The exit command would be equivalent to the "/quit" entered by the user.

Of course if you have a better idea of the implementation, do as you please and I'll see the result!

@featherbear
Copy link
Author

Woah, didn't notice you responded. But ok!
as for the icon, oh. Ok fixing it :)

@featherbear
Copy link
Author

Q. would this work?
for (int i = 0; i < lines.Length; i++)
{
if (lines[i].StartsWith("send ")) {
SendText(lines[0].Substring(5,lines[0].Length));
}
}

@featherbear
Copy link
Author

Done :)

@ORelio
Copy link
Member

ORelio commented Jul 20, 2013

That's close to what I was thinking of the Scripting bot, welll done!
Now merging :)

ORelio added a commit that referenced this pull request Jul 20, 2013
GitIgnore, AppIcon, Code optimization, Scripting Bot
@ORelio ORelio merged commit 55b49c7 into MCCTeam:Indev Jul 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants