Merged
Conversation
Member
|
Very logical suggestion, although I think I was wrong from the beginning when replacing all whitespaces when parsing botowners. I should have first splitted with "," then trimmed each name ie removing only heading and trainling whitespaces. Also, as MCC checks that no parse error occured by checking that the username retrieved from chat message only contains A-Z a-z 0-9 and _ characters, I'm not sure that a title containing a colon and a space would be considered as a valid username. Merging anyway since your suggestion is indeed appropriate :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when you make the botowners you remove the spaces so i think you have to remove spaces from here too, then name like "Paladin: medxo" will work too