highest cp will no longer be less than current cp#37
Merged
Owen1212055 merged 21 commits intoMCDiamondFire:masterfrom Apr 20, 2021
Merged
highest cp will no longer be less than current cp#37Owen1212055 merged 21 commits intoMCDiamondFire:masterfrom
Owen1212055 merged 21 commits intoMCDiamondFire:masterfrom
Conversation
(+ text gen util)
merge O_O
Contributor
|
I recommend making a new branch. You kinda pushed a lot more commits than you meant to. |
Contributor
Author
|
Owen1212055
requested changes
Apr 16, 2021
| .run((tableSet) -> { | ||
| if (!tableSet.isEmpty()) { | ||
| embed.addField("Highest Point Count", FormatUtil.formatNumber(tableSet.getResult().getInt("points")), false); | ||
| if (Integer.getInteger(genPointMetric(points, uuid)) > Integer.getInteger(FormatUtil.formatNumber(tableSet.getResult().getInt("points")))) { |
Contributor
There was a problem hiding this comment.
Integer.getInteger() will not work with these methods. I recommend adding a variable names points that stores tableSet.getResult().getInt("points") and then topPoint which stores getPointMetric(). You then can compare these numbers instead of using Integer.getInteger()
Added JoinsCommand (MCDiamondFire#38)
Owen1212055
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
very small bugfix probably not worth owen's time sorry