Some code refactors#44
Merged
Owen1212055 merged 10 commits intoMCDiamondFire:masterfrom Jul 14, 2021
LocalGoddess:master
Merged
Some code refactors#44Owen1212055 merged 10 commits intoMCDiamondFire:masterfrom LocalGoddess:master
Owen1212055 merged 10 commits intoMCDiamondFire:masterfrom
LocalGoddess:master
Conversation
I have severe depression
this will prob be denied
…d I did a local build as a verification
Owen1212055
requested changes
Jul 14, 2021
Contributor
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
Looks great regardless. Thanks for cleaning up that old code.
...ava/com/diamondfire/helpbot/bot/command/argument/impl/types/MinecraftPlayerUUIDArgument.java
Outdated
Show resolved
Hide resolved
Removed all my instances of `assert`
Contributor
|
Thanks for your contributions! |
Contributor
Author
anytime! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mainly reworked CommandHandler and did some TODOs nothing too major