Skip to content

Subcommands, custom tags, modified discordboosters#45

Merged
Owen1212055 merged 9 commits intoMCDiamondFire:masterfrom
ryandev2:master
Aug 4, 2021
Merged

Subcommands, custom tags, modified discordboosters#45
Owen1212055 merged 9 commits intoMCDiamondFire:masterfrom
ryandev2:master

Conversation

@ryandev2
Copy link
Contributor

@ryandev2 ryandev2 commented Jul 16, 2021

  • Created new directories for impl commands to be more organized, no difference front-end.
  • Redid DiscordBoostersCommand to add a small description and use mentions instead of names (doesn't actually ping the user), aswell as include a formatted time for how long this user has been boosting the server for.
  • Added a new Tags system, which allows Experts+ to add and modify custom command tags, which anyone can then use.

@ryandev2 ryandev2 changed the title categorized some commands and modified DiscordBoostersCommand Categorized commands, Redid DiscordBoostersCommand, Added Tags system Jul 17, 2021
@Owen1212055
Copy link
Contributor

A general comment, but all the tag logic should go in it's own package in the sys package. So this would include the enum, tag itself, and exceptions.

@Owen1212055
Copy link
Contributor

Additionally, should the tag commands be separate or should it be considered combining them?

Like tag add/remove/edit?

@ryandev2
Copy link
Contributor Author

ryandev2 commented Jul 17, 2021

all fixed (unpushed), except a better TagHandler / Tag cache + a proper subcommands implementation

@ryandev2 ryandev2 requested a review from Owen1212055 July 17, 2021 10:15
@ryandev2
Copy link
Contributor Author

  • All requested changes complete
  • Better Tag cache
  • Added subcommands system
  • Adapted the tag commands to use the new subcommands
  • Removed the 'tag' alias from the ?tags command in favor of ^

@ryandev2 ryandev2 changed the title Categorized commands, Redid DiscordBoostersCommand, Added Tags system Subcommands, custom tags, modified discordboosters Jul 18, 2021
@ryandev2
Copy link
Contributor Author

Subcommands have been reworked

@Owen1212055 Owen1212055 merged commit d2380a5 into MCDiamondFire:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants