Skip to content

Purge now sends deleted messages to the user.#54

Merged
Owen1212055 merged 6 commits intoMCDiamondFire:masterfrom
bencered:master
Aug 16, 2021
Merged

Purge now sends deleted messages to the user.#54
Owen1212055 merged 6 commits intoMCDiamondFire:masterfrom
bencered:master

Conversation

@bencered
Copy link
Contributor

@bencered bencered commented Aug 15, 2021

Includes date/time sent, author as a mention, and the content of the messages. Does not send media attached. Most recent messages at the top of the output. Example output:
image
Could always be changed slightly to send to a log channel in the server, although a new one would need to be created.

@ryandev2
Copy link
Contributor

I know I'm not a reviewer, but wouldn't it be nice to include some emojis/formatting and slap a SimpleDateFormat on the date instead of using #toString ?
And why not include media

@bencered
Copy link
Contributor Author

I know I'm not a reviewer, but wouldn't it be nice to include some emojis/formatting and slap a SimpleDateFormat on the date instead of using #toString ?
And why not include media

I use the RFC_1123 DateTime formatter, works the best imo. Will also add attachment support.

@ryandev2
Copy link
Contributor

I know I'm not a reviewer, but wouldn't it be nice to include some emojis/formatting and slap a SimpleDateFormat on the date instead of using #toString ?
And why not include media

I use the RFC_1123 DateTime formatter, works the best imo. Will also add attachment support.

My bad, it looked like the default to me. I don't like this format, but it's down to preference really and in the end its about functionality. I'd still propose putting some markdown though (maybe even embeds instead), but its up to you and @Owen1212055

Nice

Copy link
Contributor

@ryandev2 ryandev2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested review

@ryandev2
Copy link
Contributor

~ insert spooky dm convos ~

Copy link
Contributor

@Owen1212055 Owen1212055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help ryan!

I think that it's better off compiling a text file with the messages instead.

Date, sender, attachements (as urls), etc

Look at the code for commands like sessions logs for reference. If you need help feel free to reach out to us. If you think it shouldn't be a file I'd love to know, because I feel it may make some things easier. (Like 4K char messages)

@bencered bencered requested a review from Owen1212055 August 16, 2021 12:53
@Owen1212055 Owen1212055 merged commit bf30763 into MCDiamondFire:master Aug 16, 2021
@Owen1212055
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants