Argument modifications, LockCommand and ExternalFile modifications#60
Merged
Owen1212055 merged 9 commits intoMCDiamondFire:masterfrom Sep 12, 2021
ryandev2:master
Merged
Argument modifications, LockCommand and ExternalFile modifications#60Owen1212055 merged 9 commits intoMCDiamondFire:masterfrom ryandev2:master
Owen1212055 merged 9 commits intoMCDiamondFire:masterfrom
ryandev2:master
Conversation
# Conflicts: # src/main/java/com/diamondfire/helpbot/sys/tag/TagHandler.java
# Conflicts: # src/main/java/com/diamondfire/helpbot/bot/command/impl/other/tag/AddTagSubCommand.java # src/main/java/com/diamondfire/helpbot/bot/command/impl/other/tag/EditTagSubCommand.java # src/main/java/com/diamondfire/helpbot/bot/command/impl/other/tag/ListTagsSubCommand.java
Contributor
Author
|
I've refactored the ExternalFile system and made TagHandler take advantage of it |
ryandev2
changed the title
…e advantage of the new ExternalFile system and added a #copy method
Contributor
Author
|
Made SwearFilter, DisableCommandHandler and CodeDifferenceHandler take advantage of the new ExternalFile system and added the |
Owen1212055
requested changes
Aug 19, 2021
Contributor
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
These changes are pretty critical. Please make sure that default values with null in it still work properly.
src/main/java/com/diamondfire/helpbot/bot/command/argument/impl/types/Argument.java
Outdated
Show resolved
Hide resolved
...a/com/diamondfire/helpbot/bot/command/argument/impl/parsing/parser/SingleArgumentParser.java
Show resolved
Hide resolved
Contributor
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several argument refactors, including:
FallbackArgumentandAbstractSimpleValueFallbackArgument,which will let the argument return a custom value (
CommandEventprovided) if the normal parsed value threw an exception or is null.This also gives the possibility of having an optional argument in the middle of an
ArgumentSet.ArgumentContainer#optionalnow uses a lambda instead ofTwith theCommandEvent.TextChannelArgument(extending FallbackArgument) which will return the channel the command was executed in if the mentioned one is invalid.EnumArgument#setEnumto be in the constructor.Renamed Permission to
Rankfor convenience with JDA'sPermissionAdded LockCommand (Exclusive to
Rank.MODERATION). This command will toggle a lock in the mentioned or executed channel, and send a message with the reason for it.I do not understand how git forks work, it keeps adding old commits lol