Skip to content

Conversation

@chelojimenez
Copy link
Contributor

@chelojimenez chelojimenez commented Oct 11, 2025

Note

Use serverId (no normalization) across MCPClientManager APIs and internals, replacing serverName and related helpers.

  • API changes:
    • Rename parameters from serverName to serverId across public methods (connectToServer, disconnectServer, listTools, getTools, executeTool, list/read/subscribe/unsubscribe resources, listPrompts, getPrompt, notification hooks, elicitation handlers, etc.).
    • Change getTools argument from names?: string[] to serverIds?: string[].
    • hasServer now checks by serverId directly (no normalization).
    • Error messages now reference serverId.
  • Behavior/internal changes:
    • State maps and handler maps are keyed by serverId.
    • Remove name normalization and getClientByName; add/use getClientById.
    • Constructor iterates servers by [id, config] and connects via serverId.
    • HTTP connection and event handler wiring updated to use serverId throughout.

Written by Cursor Bugbot for commit 41d8563. This will update automatically on new commits. Configure here.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 11, 2025
cursor[bot]

This comment was marked as outdated.

Resolved conflicts in shared/mcp-client-manager/index.ts by:
- Keeping the duplicate connection check from main
- Updating it to use serverId instead of normalizedServerName
- Maintaining consistency with the serverId refactoring
@chelojimenez chelojimenez merged commit 3c432e9 into main Oct 11, 2025
1 of 2 checks passed
khandrew1 pushed a commit that referenced this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants