Conversation
- fix #69 - document all public attributes - various text/syntax fixes - fixed docs for MRC - added forgotten import of `mrc` to core/__init__.py - update CHANGELOG
|
Hello @orbeckst! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-02-21 05:03:35 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 88.07% 88.08% +0.01%
==========================================
Files 6 6
Lines 855 856 +1
Branches 146 146
==========================================
+ Hits 753 754 +1
Misses 60 60
Partials 42 42 ☔ View full report in Codecov by Sentry. |
|
Sorry, I don't know why RTD does not show up as a status check. |
|
Just going to cycle the PR, sometimes "close and open" is enough to trigger webhooks. |
|
There we go (unless @orbeckst did something in the background and "have you turned it on and off again" was just good timing :P ) |
IAlibay
left a comment
There was a problem hiding this comment.
lgtm, thanks! (couple of comments but nothing blocking)
- applied @IAlibay's suggestions - add docs for core.Grid.midpoints
|
thanks for the quick turnaround @IAlibay |
mrcto core/init.py