Skip to content

removed CCP4 module#110

Merged
orbeckst merged 3 commits intomasterfrom
remove-ccp4
May 12, 2022
Merged

removed CCP4 module#110
orbeckst merged 3 commits intomasterfrom
remove-ccp4

Conversation

@orbeckst
Copy link
Copy Markdown
Member

@orbeckst orbeckst commented Apr 30, 2022

@orbeckst
removed CCP4 module
4e2239d 
- fix #107 and #50
- removed CCP4.py and test_CCP4.py
- updated docs
- updated CHANGELOG
@orbeckst orbeckst added this to the 1.0.0 milestone Apr 30, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #110 (cc78b52) into master (6fcf00e) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   88.08%   87.56%   -0.52%     
==========================================
  Files           6        5       -1     
  Lines         856      748     -108     
  Branches      146      133      -13     
==========================================
- Hits          754      655      -99     
+ Misses         60       56       -4     
+ Partials       42       37       -5
Impacted Files Coverage Δ
gridData/OpenDX.py 82.27% <ø> (-0.93%) ⬇️
gridData/gOpenMol.py 86.11% <ø> (-0.38%) ⬇️
gridData/mrc.py 96.77% <ø> (-0.20%) ⬇️
gridData/__init__.py 100.00% <100.00%> (ø)
gridData/core.py 94.18% <100.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c72933...cc78b52. Read the comment docs.

@orbeckst orbeckst requested a review from IAlibay April 30, 2022 01:26
@orbeckst orbeckst self-assigned this Apr 30, 2022
@IAlibay
Copy link
Copy Markdown
Member

IAlibay commented Apr 30, 2022

Ah didn't see you had requested a review for this too, I'll get to it tomorrow UK time

@orbeckst
Copy link
Copy Markdown
Member Author

orbeckst commented May 1, 2022

I don't think that a mrcfile release with the fixed ccpem/mrcfile#35 is already out (the last one is 1.3.0 from Feb 2021 on https://pypi.org/project/mrcfile/) so we should not require a minimum version number (even though I think technically that would be the correct thing to do in order to claim having fixed #50 ).

@orbeckst
Copy link
Copy Markdown
Member Author

orbeckst commented May 12, 2022

@IAlibay @richardjgowers I am looking for a rubberstamp here ;-)

@IAlibay
Copy link
Copy Markdown
Member

IAlibay commented May 12, 2022

Thanks for the reminder, I'll get on it during lunch, I have a partial review which apparently I never submitted 😅

IAlibay
IAlibay approved these changes May 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one tiny thing - approving to avoid blocking.

@orbeckst @IAlibay
Update CHANGELOG
cc78b52 
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@orbeckst orbeckst merged commit e27b872 into master May 12, 2022
@orbeckst orbeckst deleted the remove-ccp4 branch May 12, 2022 15:00
@orbeckst
Copy link
Copy Markdown
Member Author

orbeckst commented May 12, 2022

Thanks Irfan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IAlibay IAlibay IAlibay approved these changes

Assignees

@orbeckst orbeckst

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

remove CCP4 module

2 participants

@orbeckst @IAlibay