Add stable/ and dev/ versions of UserGuide#110
Add stable/ and dev/ versions of UserGuide#110lilyminium wants to merge 4 commits intoMDAnalysis:masterfrom lilyminium:stable
Conversation
|
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-21 00:38:17 UTC |
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
One potential fix (for ... else?) and question regarding URL.
| if ver["version"] == version: | ||
| ver["url"] = os.path.join(URL, version) | ||
| break | ||
| else: |
There was a problem hiding this comment.
Should this else correspond to for to avoid the "multiple dev" problem?
| - | | ||
| if [[ ${TRAVIS_PULL_REQUEST} == "false" ]]; then | ||
| python -c 'import os,sys,fcntl; flags = fcntl.fcntl(sys.stdout, fcntl.F_GETFL); fcntl.fcntl(sys.stdout, fcntl.F_SETFL, flags&~os.O_NONBLOCK);' | ||
| export URL="https://userguide.mdanalysis.org/" |
There was a problem hiding this comment.
Do you prefer to set the URL in the script instead of in the travis settings? You could add it to the global variables at the top of travis.yml as one of the major configuration settings.
There are also still all the other variables that remain in the script. Why is URL moved?
There was a problem hiding this comment.
Probably just absentmindedness. This now needs to be replaced with something similar to the gh-actions pipeline in mdanalysis proper (MDAnalysis/mdanalysis#3051)
|
We should replace this with GH-actions. |
3 participants
Parallel to #2968 and #2970, this creates copies of 1.0.0 to stable/ and 2.0.0-dev0 dev/ versions of the User Guide.