Skip to content

Universe.from_smiles guide#69

Closed
cbouy wants to merge 3 commits intoMDAnalysis:masterfrom
cbouy:master
Closed

Universe.from_smiles guide#69
cbouy wants to merge 3 commits intoMDAnalysis:masterfrom
cbouy:master

Conversation

@cbouy
Copy link
Member

@cbouy cbouy commented Jun 8, 2020

@cbouy cbouy marked this pull request as ready for review June 11, 2020 18:31
@lilyminium
Copy link
Member

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add rdkit to requirements.txt as well, that's why RTD is broken at least.

I'm not sure that this will work, given that I think your SMILES stuff is still in the dev version? So this may have to wait until the next release

@cbouy
Copy link
Member Author

cbouy commented Jun 15, 2020

I'm not sure that this will work, given that I think your SMILES stuff is still in the dev version? So this may have to wait until the next release

Yes it's still in a PR for now

@cbouy
Copy link
Member Author

cbouy commented Jun 19, 2020

It's been merged to develop and scheduled for 2.0.0

@lilyminium
Copy link
Member

Thanks @cbouy! I might ask you to write up a short doc on the rdkit format in a little while (similar to the ones in #77) but I'll try to sort out versioning first.

@lilyminium
Copy link
Member

@cbouy would you mind rebasing on master and seeing if RTD can build after? Thank you!

@cbouy
Copy link
Member Author

cbouy commented Jan 4, 2021

@lilyminium looks like you might have to get in touch with the RTD team so that they can increase the memory limit allocated to this project. The build fails when installing the dependencies needed by RTD (creating the environment works just fine).

@lilyminium
Copy link
Member

Thanks @cbouy, I thought I fixed that in master but looks like rdkit pushed it over the edge again.

@lilyminium
Copy link
Member

Thanks to the wonderful folks at ReadTheDocs, the test builds now! Unfortunately master is still for MDA version 1.0.0. Could I ask you to close this request to master and open a new one to develop please, @cbouy? And to add yourself to doc/source/AUTHORS :-)

@cbouy cbouy mentioned this pull request Jan 5, 2021
@cbouy
Copy link
Member Author

cbouy commented Jan 5, 2021

Done!

@cbouy cbouy closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants