-
Notifications
You must be signed in to change notification settings - Fork 824
Closed
Labels
Component-WritersdeprecationDeprecated functionality to give advance warning for API changes.Deprecated functionality to give advance warning for API changes.usability
Milestone
Description
As discussed in #206 we want to streamline the trajectory writer interface so that
Writer.write(arg)only accepts AtomGroup or Universe as arg but not Timestep anymore. (We can't think of a good reason when we would have a Timestep but not an AG.)
- deprecate the part of
base.Writer.write()that can directly take amdanalysis/package/MDAnalysis/coordinates/base.py
Line 2146 in 388346d
if isinstance(obj, Timestep): Timestep - check all specific Writers that we don't override
- add comments that in 1.0 supplying a
Timestepwill raise aTypeError - add tests for all writers that check for the deprecation warning (and can later be turned into tests that check for
TypeError) - check docs and replace deprecated usage
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Component-WritersdeprecationDeprecated functionality to give advance warning for API changes.Deprecated functionality to give advance warning for API changes.usability