Skip to content

Align behaviour of waterdynamics.SurvivalProbability with other analysis methods #2524

@IAlibay

Description

@IAlibay

Description

Relates to #2505 (review)

Currently waterdynamics.SurvivalProbability:

  1. Accepts the deprecated t0, tf, and dtmax keywords in :meth:SurvivalProbability.__init__, which override the setting of start, stop, and tau_max in :meth:SurvivalProbability.run.
  2. Uses the stop (or aforementioned tf) keyword to set the final frame inclusively (rather than exclusively as done by most other analysis methods).

Describe the solution you'd like

  1. Remove the deprecated keywords, making the behaviour similar to :class:AnalysisBase methods.
  2. Make stop exclusive rather than inclusive.

Additional context
This is would complement #2505 and is a goal towards #2443

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions