Conversation
|
My impression is that the script was working well, but maybe not quite perfectly, so we should check the results carefully (this is rather obvious given the number of files changed). |
|
Some headers got changed because one of the lines was over 80 chars, so
it'd be worth checking if both variants of our standard header got changed.
Iirc the change was around Oliver's name.
…On Sun, 27 Nov 2016, 6:48 p.m. Tyler Reddy, ***@***.***> wrote:
My impression is that the script was working well, but maybe not quite
perfectly, so we should check the results carefully (this is rather obvious
given the number of files changed).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1088 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI0jB9qul_MY9CVYB3Vc06Is4P9abhvgks5rCdBogaJpZM4K9IMQ>
.
|
|
@richardjgowers the script didn't check for exact matches of the old so that should be fine. I also did a manual check of the files touched shown with |
|
@kain88-de Should be no problem to change Encore to GPLv2. I'll just check with the others to make sure. |
|
@kain88-de Everyone is OK with the change to GPLv2. Can this change be done automatically by the script, or do we manually need to change the headers? |
|
@wouterboomsma I would then modify the script to also change all encore headers to the default headers. I can't script everything because you have comments about the license also in the docs. But not that many files so it's doable. |
update all headers
Fixes #993, #1002
I updated the licence headers using the script from @tylerjereddy. Updating the old PR wasn't an option due to rebase errors.
I noticed that the encore license headers aren't changed by the script. The whole encore package is licensed under GPLv3 with wrong time marks for the copyright and authors. The whole code in encore is only attributed to @wouterboomsma and @mtiberti though gitlog also shows at least one other constributor @tbengtsen. The GPL3 is actually a problem since the licenses are not backwards compatible it is ok for the encore parts to use MDAnalysis but not the other way around. The easiest solution to this would be if we can change encore to GPLv2 like the rest of MDAnalysis.
PR Checklist
[ ] Tests?[ ] Docs?[ ] CHANGELOG updated?