Skip to content

[MRG] Make knownfailure work even without parentheses#1218

Merged
richardjgowers merged 5 commits intoMDAnalysis:developfrom
Akshay0724:KnownFailure
Feb 25, 2017
Merged

[MRG] Make knownfailure work even without parentheses#1218
richardjgowers merged 5 commits intoMDAnalysis:developfrom
Akshay0724:KnownFailure

Conversation

@Akshay0724
Copy link
Contributor

@Akshay0724 Akshay0724 commented Feb 24, 2017

Fixes #731

Changes made in this Pull Request:

  • modified mdanalysis/testsuite/MDAnalysisTests/plugins/knownfailure.py to support knownfailure decorator to work with and without parentheses.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@richardjgowers
Copy link
Member

@Akshay0724 looks good, can you also change where we currently use knownfailure() to not use the brackets? git grep 'knownfailure() gives me:

testsuite/MDAnalysisTests/__init__.py:plugin provides the `@knownfailure()` decorator, which can be used to mark tests
testsuite/MDAnalysisTests/coordinates/test_dcd.py:    @knownfailure()
testsuite/MDAnalysisTests/plugins/knownfailure.py:Beware that the decorator must be used as a function call: `@knownfai
testsuite/MDAnalysisTests/test_streamio.py:    @knownfailure()

The docs in __init__.py need updating to reflect that we don't need the brackets any more

@richardjgowers richardjgowers self-assigned this Feb 24, 2017
@richardjgowers richardjgowers added this to the 0.16.0 milestone Feb 24, 2017
@richardjgowers
Copy link
Member

Looks good if travis passes. You can add yourself to the AUTHORS list if you want to as well.

@Akshay0724
Copy link
Contributor Author

Akshay0724 commented Feb 24, 2017 via email

@richardjgowers richardjgowers merged commit d2cafc5 into MDAnalysis:develop Feb 25, 2017
orbeckst added a commit that referenced this pull request Dec 21, 2023
Update of AUTHORS and CHANGELOG with inferred author contributions.

*  Removed duplicate mattwthompson in 0.20.0 changelog entry.: mattwthompson was placed twice by accident, this removes this duplication.

* Addition of missing authors.

   An retrospective analysis of the authors found via `git shortlog -s -n --email --branches="develop"` found several commits by authors which were not present in the `AUTHORS.md` file.

    - Zhenbo Li: commited via PR: Started tests for gnm. #803 and Make Travis run tests on OSX. #771,
    - Jenna M. Swarthout via PR Update CoC according to suggestions from current CoC committee #4289 and Point to new reporting form link (owned by conduct@mdanalysis.org) #4298,
    - Bradley Dice via PR   Fix GSD Windows compatibility #2384 ,
    - David Minh via PR #2668

   There seemed to be no indications in the above mentioned PRs that the author did not want to be in the authors file, it looks like it was just forgotten.

* Addition of missing entries from the changelog

   Continued cross referencing of the git shortlog output but also accounting for the changelog identified several individuals that had not been included in the changelog entries for the release they contributed under. They were added to the relevant entry of the changelog based on the merge commit date.

   Please note that for Tone Bengsten, we a) had no github handle (so they were assigned @tbengtsen), and b) no specific commit. Given we know that this individual was including alongside the encore merge, they were assigned to the 0.16.0 release.

* Update CHANGELOG
* PR #1218
* PR #1284 and #1408
* PR #4109
* based on git history
* PRs #803 and #771 (author addition, changelog addition)
* PR #2255 and #2221
* PR #1225
* PR #4289 and #4298
* PR #4031
* PR #4085
* PR #3635
* PR #2356
* PR #2559
* No GH handle - Encore author addition @tbengtsen
* PR #4184
* PR #2614
* PR #2219
* PR #2384
* PR #2668
* Add missing entry for Jenna

Thanks to @fiona-naughton for helping out with digging into this data :)

Co-authored-by: Fiona Naughton <fiona@mdanalysis.org>
Co-authored-by: Oliver Beckstein <orbeckst@mdanalysis.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants