Conversation
this also includes a short test of the if structure to see if it works in the PR already.
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
No idea why this script does not understand test: it is a common Linux command.
But fix the bash syntax errors, check that it passes, and remove the dummy message.
.travis.yml
Outdated
| script: | ||
| - cd ${TRAVIS_BUILD_DIR} | ||
| - if [[ $TRAVIS_OS_NAME == 'osx' ]]; then ulimit -S -n 2048; fi | ||
| - if [[ ${TRAVIS_PULL_REQUEST} == "true" && \ |
There was a problem hiding this comment.
Do you want to keep this?? I assume it should be removed before merging.
There was a problem hiding this comment.
I wanted to check my code as best as I could before we merge this to master to make sure it works. So yeah this will be removed before the merge
.travis.yml
Outdated
| - cd ${TRAVIS_BUILD_DIR} | ||
| - if [[ $TRAVIS_OS_NAME == 'osx' ]]; then ulimit -S -n 2048; fi | ||
| - if [[ ${TRAVIS_PULL_REQUEST} == "true" && \ | ||
| ${BUILD_DOCS} == "true"]]; then \ |
There was a problem hiding this comment.
Syntax error: you need a space between "true" and ]].
Travis completely fails on this at the moment.
.travis.yml
Outdated
| bash ${TRAVIS_BUILD_DIR}/maintainer/deploy_docs.sh; | ||
| - if [[ ${TRAVIS_PULL_REQUEST} == "false" && \ | ||
| ${TRAVIS_BRANCH} == ${GH_DOC_BRANCH} && \ | ||
| ${BUILD_DOCS} == "true"]]; then \ |
|
I quickly fixed the bash syntax errors using GitHub edit. Let's see what travis says. |
|
@orbeckst seems like you also didn't fix all errors. |
|
Not sure what the issue is Any ideas? |
Need yaml continuation blocks for multiline bash.
|
I think we needed yaml continuation blocks - |
if ... stuff \
more stude... let's see if this did it. |
|
I don't think that the "Yeah it works" was actually echoed: https://travis-ci.org/MDAnalysis/mdanalysis/jobs/226159706#L658 This is the Travis task that has |
|
I can't see it either. |
|
This PR #1284 changed the deploy section of the travis config. I'll try using the old version again. |
|
OK I really broke everything again now. Strange |
|
OK the problem is that TRAVIS_PULL_REQUEST doesn't contain what we thought it would. |
|
That's good to know! |
|
@orbeckst the solution i arrived at now works as far as I can tell. You can merge/squash this if you are ok with it. |
2 participants
this also includes a short test of the if structure to see if it works in the PR
already.
Fixes #1316
Changes made in this Pull Request:
PR Checklist
- [ ] Tests?- [ ] CHANGELOG updated?