Conversation
|
@rathann if you want you can add your name to AUTHORS to get some credit for your work |
|
Oh, and don't squash this so we keep both authors |
kain88-de
left a comment
kain88-de
left a comment
There was a problem hiding this comment.
LGTM besides one small comment
| """32 bit compat tests | ||
|
|
||
| Tests for making sure that integer arrays used for indexing | ||
| use `np.intp` |
There was a problem hiding this comment.
maybe add here that np.intp is a platform independent type for indexing in numpy.
richardjgowers
force-pushed
the
issue-1362-int_types
branch
from
a1f542b to
829f33b
Compare
|
@kain88-de (#1393 (comment)) maybe you or @richardjgowers (or I) can add @rathann to the authors? He cannot push to this branch and would need a PR against this PR... @rathann can you please provide the information for packages/AUTHORS (namely, your full name if you want to be listed with it, otherwise any handle that you'd like to use) as a comment on this PR so that one of us can quickly add you? |
This fixes ERRORs and FAILs in the testsuite on 32bit:
TypeError: Cannot cast array data from dtype('int64') to dtype('int32') according to the rule 'safe'
and
assert_(out[0].dtype == np.int64)
File "/usr/lib/python2.7/site-packages/numpy/testing/utils.py", line 92, in assert_
raise AssertionError(smsg)
AssertionError
- Added tests for 32 bit index support - added @rathann to AUTHORS
I found your name in the submitter email and I am adding you to AUTHORS. Welcome as a MDAnalysis contributor (you'll also get a GitHub invite). |
orbeckst
force-pushed
the
issue-1362-int_types
branch
from
829f33b to
eed7761
Compare
|
I rebased against develop and added @rathann to AUTHORS. |
|
Thank you! |
4 participants
Fixes (partially) #1362
Supercedes #1391
Changes made in this Pull Request:
PR Checklist