fix int type in asserts in TestDownshiftArrays#1410
Merged
richardjgowers merged 10 commits intoMDAnalysis:developfrom Jun 19, 2017
rathann:develop
Merged
fix int type in asserts in TestDownshiftArrays#1410richardjgowers merged 10 commits intoMDAnalysis:developfrom rathann:develop
richardjgowers merged 10 commits intoMDAnalysis:developfrom
rathann:develop
Conversation
This fixes ERRORs and FAILs in the testsuite on 32bit:
TypeError: Cannot cast array data from dtype('int64') to dtype('int32') according to the rule 'safe'
and
assert_(out[0].dtype == np.int64)
File "/usr/lib/python2.7/site-packages/numpy/testing/utils.py", line 92, in assert_
raise AssertionError(smsg)
AssertionError
Removed TestCase usage
- Added tests for 32 bit index support - added @rathann to AUTHORS
Groups (AtomGroup, ResidueGroup, SegmentGroup) cannot be stored in sets or used as dict key if they are not hashable. In python 3, the __hash__ method is not defined implicitly anymore when a class has a __eq__ method. Fixes #1397
this was missed in eed7761
richardjgowers
approved these changes
Jun 19, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #1362 .
Changes made in this Pull Request:
PR Checklist
Not sure what I broke when syncing my fork to upstream, but it's showing 10 commits instead of 1 now. :(