Skip to content

REF: Format to order for timeseries#1751

Merged
richardjgowers merged 4 commits intodevelopfrom
format-to-order
Jan 5, 2018
Merged

REF: Format to order for timeseries#1751
richardjgowers merged 4 commits intodevelopfrom
format-to-order

Conversation

@kain88-de
Copy link
Member

@kain88-de kain88-de commented Jan 2, 2018 •
edited
Loading

Fixes #1453

Changes made in this Pull Request:

  • rename format='fac' to order='fac'
  • add deprecation tests
  • fix deprecations in library

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@kain88-de
Copy link
Member Author

kain88-de commented Jan 2, 2018

Please do not merge as is! There are asserts in the deprecation warnings I'm using to ensure the whole library is updated to using order. Once the test-suite passes I'm going to turn on the deprecation tests and remove the asserts.

kain88-de
kain88-de commented Jan 2, 2018
View reviewed changes
package/MDAnalysis/coordinates/DCD.py Outdated
`skip` has been deprecated in favor of the standard keyword `step`.

.. deprecated:: 0.17.0
`format` has been deprecated in favor of the standard keyword `step`.
Copy link
Member Author

@kain88-de kain88-de Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step -> order

package/MDAnalysis/coordinates/memory.py Outdated


.. deprecated:: 0.17.0
`format` has been deprecated in favor of the standard keyword `step`.
Copy link
Member Author

@kain88-de kain88-de Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@kain88-de
change format -> order for timeseries method
1d546b5 
This now follows the agreed upon standard name
@kain88-de
write deprecation tests
998a157
@kain88-de
fix deprecation warnings occurrences in code
7f8be19 
check that no test code throws the deprecation warning
@kain88-de
update CHANGELOG
041d553
@kain88-de
Copy link
Member Author

kain88-de commented Jan 2, 2018

This is good to go now from my perspective

@richardjgowers richardjgowers merged commit 6e71ffe into develop Jan 5, 2018
@richardjgowers richardjgowers deleted the format-to-order branch January 5, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardjgowers richardjgowers richardjgowers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

change timeseries "format" kw to "order"

2 participants

@kain88-de @richardjgowers