Skip to content

Issue 1004 unwrap#2012

Closed
richardjgowers wants to merge 5 commits intodevelopfrom
issue-1004-unwrap
Closed

Issue 1004 unwrap#2012
richardjgowers wants to merge 5 commits intodevelopfrom
issue-1004-unwrap

Conversation

@richardjgowers
Copy link
Member

Fixes #1004

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

Merging #2012 into develop will decrease coverage by 0.11%.
The diff coverage is 11.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2012      +/-   ##
===========================================
- Coverage     88.5%   88.39%   -0.12%     
===========================================
  Files          143      143              
  Lines        17249    17273      +24     
  Branches      2646     2656      +10     
===========================================
+ Hits         15266    15268       +2     
- Misses        1385     1408      +23     
+ Partials       598      597       -1
Impacted Files Coverage Δ
package/MDAnalysis/core/groups.py 94.76% <11.53%> (-2.61%) ⬇️
package/MDAnalysis/lib/transformations.py 78.62% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461aadf...408b084. Read the comment docs.

@richardjgowers richardjgowers mentioned this pull request Sep 14, 2018
4 tasks
@orbeckst
Copy link
Member

@richardjgowers is this PR still active?

The issue #1004 is still open and presumably, in the area of PBC/making whole we still have some work to do, at least from reading #1185 . Is this also your sense?

@richardjgowers
Copy link
Member Author

@orbeckst yeah this PR is still relevant. Our current 'pbc' option equates to 'wrap', ie pack everything in before calculating an answer. What most people need is actually 'unwrap' ie make the molecule whole before giving me an answer. This PR would try and do that.

@zemanj zemanj mentioned this pull request Jan 30, 2019
4 tasks
@RMeli RMeli deleted the issue-1004-unwrap branch February 18, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants