Conversation
|
Thank you for the pull request. I do not have time to look at it right now, but I'll have a look as soon as possible if nobody reviewed the PR in the meantime. For the tests to run, you need to add |
|
I did not see it was related to #2011. |
|
Thanks for pointing that out. Maybe after I've corrected that @richardjgowers can have a look. |
| fline = inf.readline() | ||
| try: | ||
| float(fline.split()[1]) | ||
| except: |
There was a problem hiding this comment.
Catching all exception classes, including keyboard interruptions, might not be desired
Indeed, clarifying if this PR is still relevant / needed might be useful given period of inactivity. |
|
Closing as stale, feel free to re-open if you want to continue. |
Fixes #
Changes made in this Pull Request:
PR Checklist