removed use of pytest.approx

[richardjgowers]

Fixes #

Changes made in this Pull Request:

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

[codecov]

Codecov Report

Merging #2019 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2019   +/-   ##
========================================
  Coverage    88.45%   88.45%           
========================================
  Files          143      143           
  Lines        17223    17223           
  Branches      2637     2637           
========================================
  Hits         15234    15234           
  Misses        1389     1389           
  Partials       600      600

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3331c8d...96af8ad. Read the comment docs.

[richardjgowers]

@MDAnalysis/coredevs ok this seems to fix travis woes (for this week....)

[orbeckst]

LGTM.

(Out of curiosity, where did you encounter problems with the mock decorator?)

[richardjgowers]

@orbeckst we'd get errors like below. It looks like pytest is looking for the thing that mock should be supplying (since they both use weird automatic argument filling)

_________________ ERROR at setup of TestMMTFFetch.test_altlocs _________________
[gw0] linux -- Python 3.6.6 /home/travis/miniconda/envs/test/bin/python
file /home/travis/build/MDAnalysis/mdanalysis/testsuite/MDAnalysisTests/topology/test_mmtf.py, line 75
      def test_altlocs(self, u):
file /home/travis/build/MDAnalysis/mdanalysis/testsuite/MDAnalysisTests/topology/test_mmtf.py, line 110
      @pytest.fixture()
      @mock.patch('mmtf.fetch')
      def u(self, mock_fetch):
E       fixture 'mock_fetch' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, tmpdir, tmpdir_factory, u, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

[orbeckst]

Thanks, good to know.

…

On Aug 4, 2018, at 10:47 AM, Richard Gowers ***@***.***> wrote: @orbeckst <https://github.com/orbeckst> we'd get errors like below. It looks like pytest is looking for the thing that mock should be supplying (since they both use weird automatic argument filling)