Around keyword can use KDTree for periodic boundary conditions#2022
Merged
richardjgowers merged 3 commits intoMDAnalysis:developfrom Aug 5, 2018
Merged
Around keyword can use KDTree for periodic boundary conditions#2022richardjgowers merged 3 commits intoMDAnalysis:developfrom
richardjgowers merged 3 commits intoMDAnalysis:developfrom
Conversation
Member
|
Can you rebase, the failures are unrelated |
Codecov Report
@@ Coverage Diff @@
## develop #2022 +/- ##
==========================================
Coverage ? 88.45%
==========================================
Files ? 143
Lines ? 17225
Branches ? 2637
==========================================
Hits ? 15237
Misses ? 1389
Partials ? 599
Continue to review full report at Codecov.
|
richardjgowers
approved these changes
Aug 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Around keyword only used _apply_distmat if periodic keyword was active. Both brute force and kdtree routines can be used now for PBC and non-PBC calculations
Fixes partly #974
PR Checklist