Use stricter type for pkdtree indices#2025
Merged
tylerjereddy merged 1 commit intodevelopfrom Aug 5, 2018
Merged
Conversation
Using consistently np.int64 for the indices used in pkdtree avoids type errors when using unique_int_1d. This should reduce the number of failing tests on windows.
Contributor
Author
|
AppVeyor failures go down back to 13. |
Codecov Report
@@ Coverage Diff @@
## develop #2025 +/- ##
========================================
Coverage 88.45% 88.45%
========================================
Files 143 143
Lines 17223 17223
Branches 2637 2637
========================================
Hits 15234 15234
Misses 1389 1389
Partials 600 600
Continue to review full report at Codecov.
|
tylerjereddy
approved these changes
Aug 5, 2018
Member
tylerjereddy
left a comment
tylerjereddy
left a comment
There was a problem hiding this comment.
LGTM -- back to original Windows test suite failure count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using consistently np.int64 for the indices used in pkdtree avoids type
errors when using unique_int_1d. This should reduce the number of
failing tests on windows.
PR Checklist