Skip to content

Issue 443 cythoncoverage#2032

Closed
seb-buch wants to merge 101 commits intoMDAnalysis:issue-443-cythoncoveragefrom
seb-buch:issue-443-cythoncoverage
Closed

Issue 443 cythoncoverage#2032
seb-buch wants to merge 101 commits intoMDAnalysis:issue-443-cythoncoveragefrom
seb-buch:issue-443-cythoncoverage

Conversation

@seb-buch
Copy link
Contributor

@seb-buch seb-buch commented Aug 8, 2018

Fixes #443, #2029

For some reason I don't have permission to push to the issue-443-cythoncoverage branch so here is a PR.

Changes made in this Pull Request:

  • setup.py modified so Cython extensions are compiled with coverage-compliant options when environment variable CYTHON_TRACE_NOGIL is set.
  • Added .coveragerc to enable Cython.coverage plugin (needed to read cythonized file to write coverage report)

ayushsuhane and others added 30 commits August 5, 2018 18:54
kain88-de and others added 24 commits August 8, 2018 14:57
…nction to take coordinates as input, modified tests accordingly
Removed dict from buffers from speedup, seperated search and self_search, construct a grid and search with another grid
* all unit tests that currently fail or error on
Windows (Appveyor) will now strictly xfail

* Appveyor test suite failure is no longer allowed
in CI--this prevents regressions in Windows compatibility
progress; the objective now is to reduce xfails instead
of actual failures
…environment variable CYTHON_TRACE_NOGIL is set
@richardjgowers
Copy link
Member

@seb-buch I checked and you should have permission, I think it might have been that the branch needed a rebase before you could push. I've cherry picked the commit onto #2029

@orbeckst
Copy link
Member

orbeckst commented Aug 8, 2018

@richardjgowers (with new avatar...) and @seb-buch can we close this PR then?

@orbeckst
Copy link
Member

orbeckst commented Aug 8, 2018

(It is also very weird that only appveyor ran on this branch.)

@seb-buch seb-buch closed this Aug 9, 2018
@seb-buch
Copy link
Contributor Author

seb-buch commented Aug 9, 2018

I closed the PR since @richardjgowers cherry picked the relevant commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants