Improved docstrings in lib/_augment.pyx#2062
Improved docstrings in lib/_augment.pyx#2062richardjgowers merged 7 commits intoMDAnalysis:developfrom
Conversation
|
@ayushsuhane Since you wrote the augment routines (PR #1977), could you take a quick look at the new docstrings? Just to make sure I didn't add any bogus. 😉 |
Codecov Report
@@ Coverage Diff @@
## develop #2062 +/- ##
========================================
Coverage 89.26% 89.26%
========================================
Files 159 159
Lines 18678 18678
Branches 2673 2673
========================================
Hits 16672 16672
Misses 1403 1403
Partials 603 603
Continue to review full report at Codecov.
|
|
Mmmh... nobody up to reading some good ol' poetry? 😄 |
|
@zemanj Looks good. The docs are more clear now. Thanks!! 👍 |
richardjgowers
left a comment
There was a problem hiding this comment.
thanks for the review @ayushsuhane
|
The develop build is now failing for Python 3.4 due to an unresolvable conda dependency. I restarted the build but the problem persists. |
Fixes (partially) #2046, this is the second of a series of related PRs, following PR #2048.
Changes made in this Pull Request:
MDAnalysis.lib.distances.augment_coordinates()andMDAnalysis.lib.distances.undo_augment()to better explain what the methods are actually doing... autofunctioninlib/distances.pyso that the signatures of both functions are now properly displayed in the html docs.lib.distancesa bit #2048 so thatdistance_array()now also returns an array for single coordinate input.lib.distancesa bit #2048.Apparently, there is a problem with Windows/Linux (i.e., CRLF vs. LF) line endings resulting in an incorrect
git diffoutput forlib/_augment.pyx, which now looks as if I changed every line in the file, even though I only changed the docstrings. Withgit diff -bthe changes are displayed correctly, though. On github, just change the diff settings to ignore whitespace.PR Checklist