Skip to content

maybe xdist is screwing up?#2145

Merged
orbeckst merged 1 commit intodevelopfrom
fix-3.6-travis
Nov 21, 2018
Merged

maybe xdist is screwing up?#2145
orbeckst merged 1 commit intodevelopfrom
fix-3.6-travis

Conversation

@richardjgowers
Copy link
Copy Markdown
Member

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@richardjgowers
Copy link
Copy Markdown
Member Author

@MDAnalysis/coredevs ok so removing the --numprocesses=2 makes the travis build work again, and only increases the test times by about 1-2 min.

Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it... xdist has been a constant source of frustration

@orbeckst orbeckst merged commit aaf2f9a into develop Nov 21, 2018
@orbeckst orbeckst deleted the fix-3.6-travis branch November 21, 2018 22:54
@orbeckst
Copy link
Copy Markdown
Member

@richardjgowers can you tell the fine folks on the dev list to merge/rebase their failing PRs?

Thanks for diagnosing the problem.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2018

Codecov Report

Merging #2145 into develop will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2145     +/-   ##
==========================================
- Coverage    89.42%   89.23%   -0.2%     
==========================================
  Files          157      143     -14     
  Lines        18772    17473   -1299     
  Branches      2711     2711             
==========================================
- Hits         16787    15592   -1195     
+ Misses        1381     1277    -104     
  Partials       604      604
Impacted Files Coverage Δ
topology/base.py
auxiliary/base.py
util.py
__init__.py
formats/__init__.py
visualization/__init__.py
coordinates/__init__.py
auxiliary/__init__.py
datafiles.py
core/__init__.py
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c48f6...eed61d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants