Adds test coverage to Cython files#2254
Adds test coverage to Cython files#2254fenilsuchak wants to merge 0 commit intoMDAnalysis:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2254 +/- ##
=======================================
Coverage 89.7% 89.7%
=======================================
Files 160 160
Lines 19769 19769
Branches 2783 2783
=======================================
Hits 17733 17733
Misses 1440 1440
Partials 596 596Continue to review full report at Codecov.
|
|
@Fenil3510 we can't add the c/cpp files to ignore because we do include them in the master branch. So releases don't require Cython. |
package/setup.py
Outdated
| "parallelization module".format( | ||
| Cython.__version__, required_version)) | ||
| cython_found = False | ||
| cython_linetrace = True |
There was a problem hiding this comment.
Ideally this isn't on by default as I'm guessing it has a performance cost. We could probably look for one of the travis/CI environment variables to trigger this?
There was a problem hiding this comment.
Yes, this is not a default one and there's an environment variable to trigger this as you had already done in #2029, but I was forcing this to look at the results for now.
|
|
The |
Changes made in this Pull Request:
PR Checklist