MAINT: bumpy minimum NumPy required to 1.13.3#2283
Merged
richardjgowers merged 1 commit intoMDAnalysis:developfrom Jul 1, 2019
Merged
MAINT: bumpy minimum NumPy required to 1.13.3#2283richardjgowers merged 1 commit intoMDAnalysis:developfrom
richardjgowers merged 1 commit intoMDAnalysis:developfrom
Conversation
Member
Author
|
Can't remember if we have different build-time (i.e., numpy-distutils) vs. runtime NumPy version requirements, but maybe having them the same is less confusing anyway. |
Codecov Report
@@ Coverage Diff @@
## develop #2283 +/- ##
========================================
Coverage 89.66% 89.66%
========================================
Files 172 172
Lines 21398 21398
Branches 2785 2785
========================================
Hits 19186 19186
Misses 1616 1616
Partials 596 596Continue to review full report at Codecov.
|
richardjgowers
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2272
I adjusted the minimum required NumPy version to
1.13.3for the relevant machinery I could find specifying1.10.4usinggit grepon our code base, but I did this quickly so we'll see what CI says.I added a CHANGELOG entry too--one thought that occurred to me that is that people who put in review effort might not get acknowledged in that log, but that's a debate for another time maybe.
Also perhaps for another time, given current bandwidth, is establishing a clearer policy on major dependency version bumps, as noted in linked issue I think.