Skip to content

MAINT: bumpy minimum NumPy required to 1.13.3#2283

Merged
richardjgowers merged 1 commit intoMDAnalysis:developfrom
tylerjereddy:bump_numpy
Jul 1, 2019
Merged

MAINT: bumpy minimum NumPy required to 1.13.3#2283
richardjgowers merged 1 commit intoMDAnalysis:developfrom
tylerjereddy:bump_numpy

Conversation

@tylerjereddy
Copy link
Member

Fixes #2272

I adjusted the minimum required NumPy version to 1.13.3 for the relevant machinery I could find specifying 1.10.4 using git grep on our code base, but I did this quickly so we'll see what CI says.

I added a CHANGELOG entry too--one thought that occurred to me that is that people who put in review effort might not get acknowledged in that log, but that's a debate for another time maybe.

Also perhaps for another time, given current bandwidth, is establishing a clearer policy on major dependency version bumps, as noted in linked issue I think.

@tylerjereddy
Copy link
Member Author

Can't remember if we have different build-time (i.e., numpy-distutils) vs. runtime NumPy version requirements, but maybe having them the same is less confusing anyway.

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #2283 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2283   +/-   ##
========================================
  Coverage    89.66%   89.66%           
========================================
  Files          172      172           
  Lines        21398    21398           
  Branches      2785     2785           
========================================
  Hits         19186    19186           
  Misses        1616     1616           
  Partials       596      596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c820cc5...7a4b5f1. Read the comment docs.

@richardjgowers richardjgowers merged commit b0c70cd into MDAnalysis:develop Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures due to wrong scipy version being installed

2 participants